You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now mostly re-using the AddressAnalysis for walking the IR. Except for IfElse statements, where we need to take care when merging results from branches.
To do this, I had to make a small change to AddressAnalysis, but that shouldn't affect anything else.
Probably needs more tests, but basics seem to work quite well.
Also, we might need some wrapper around running this analysis to have a decent UX when trying to study the fidelity of a given program.
@weinbe58 I'm also not sure if I'm being to strict about expecting an AddressReg for qubtis: IList[Qubit] arguments.
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one comment on the implementation of IfElse. Also I would add a test to make sure that you execute only one branch if the branch value is known at compile time.
@weinbe58 I'm also not sure if I'm being to strict about expecting an AddressReg for qubtis: IList[Qubit] arguments.
It depends on the situation, the short has is AddressReg is an IList of all qubits with known addresses PartialIList if some of the qubit in the list have a known address and some have UnknownQubit or if the size of the array is known at compile time and finally UnknownReg you know its an IList of qubit values but you have no idea the size of the list.
@weinbe58 Thanks for the review. The IfElse impls was somewhat left over from a previous version. It was also missing the return values. I fixed that, added the constant condition evaluation and a test.
It depends on the situation, the short has is AddressReg is an IList of all qubits with known addresses PartialIList if some of the qubit in the list have a known address and some have UnknownQubit or if the size of the array is known at compile time and finally UnknownReg you know its an IList of qubit values but you have no idea the size of the list.
I suppose it's fine then. Basically, the fidelity analysis will give up whenever there is any qubit without a known address. Technically, we could update the fidelity at least for the known qubits, but something's bound to go wrong in this case anyway since at least for one qubit the fidelity will be off.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592 .
We are now mostly re-using the
AddressAnalysisfor walking the IR. Except forIfElsestatements, where we need to take care when merging results from branches.To do this, I had to make a small change to
AddressAnalysis, but that shouldn't affect anything else.Probably needs more tests, but basics seem to work quite well.
Also, we might need some wrapper around running this analysis to have a decent UX when trying to study the fidelity of a given program.
@weinbe58 I'm also not sure if I'm being to strict about expecting an
AddressRegforqubtis: IList[Qubit]arguments.